Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add dependsOn ^deploy for each package #936

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix: Add dependsOn ^deploy for each package #936

merged 2 commits into from
Sep 20, 2023

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Sep 20, 2023 •
edited
Loading

Description

This PR adds the "dependsOn": ["^deploy"] on the deploy target of each package and not handle it from the workspace in nx.json

Fixes #932

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title Add dependsOn ^deploy for each package fix: Add dependsOn ^deploy for each package Sep 20, 2023
@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Sep 20, 2023
@kujtimprenkuSQA kujtimprenkuSQA linked an issue Sep 20, 2023 that may be closed by this pull request
Remove deploy from nx.json and add dependsOn on each project #932
Closed
@kujtimprenkuSQA kujtimprenkuSQA merged commit bc7a143 into dev Sep 20, 2023
22 of 27 checks passed
@kujtimprenkuSQA kujtimprenkuSQA deleted the 932-remove-deploy-from-nx-json branch September 20, 2023 14:42
@erditkurteshiSQA erditkurteshiSQA mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erditkurteshiSQA erditkurteshiSQA erditkurteshiSQA approved these changes

@HarisSQA HarisSQA Awaiting requested review from HarisSQA

Assignees

@kujtimprenkuSQA kujtimprenkuSQA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deploy from nx.json and add dependsOn on each project
2 participants
@kujtimprenkuSQA @erditkurteshiSQA